fix(debug-log): include app version in the System Info header - #1688
Merged
Conversation
Record the packaged application version in each debug log's System Info header so support can identify the release that produced it. Cover the header contents and keep the current logger Electron test double aligned with the added API.
Chadpiha
force-pushed
the
fix/debug-log-app-version
branch
from
August 26, 2026 22:28
ab396af to
1f3a176
Compare
Chadpiha
approved these changes
Aug 26, 2026
Chadpiha
left a comment
Chadpiha
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Josh! The fix correctly adds the application version to the debug log’s System Info header and keeps the current Electron test doubles aligned with the new API. I verified both startup and runtime debug-logging paths, with 14/14 targeted tests and the full 3,208-test suite completing with 0 failures. No regressions, cross-platform concerns, or API/dependency changes found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Customer debug logs record platform, Node, and Electron versions but not the app's own version, so the first triage question — which release produced this log — is unanswerable.
Fix: Add
appVersion: app.getVersion()as the first field of the System Info header that debugLogger writes when file logging initializes; regression test covers the header contents.Root cause
debugLogger.initializeFileLogging()logs a System Info header built only fromprocess-derived fields;app.getVersion()was never included, and nothing else in the log carries the release version.Tests
test/helpers/debugLogger.test.js(electron mocked via require-cache, per the existingdownloadUtils.test.jspattern) fails on current main:The input did not match the regular expression /appVersion/.Provenance
Contributing defect #4 from the CUS-113 RCA (Titan
wiki/areas/engineering/whisper-server-dll-not-found-rca.md): triagingdebug-2026-08-17T12-23-22-137Z.logrequired inferring the app version 1.8.x from Electron 41.10.0. Companion packaging fix: #1687.🤖 Generated with Claude Code